[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive wit

From: Ari Roponen
Subject: bug#11464: 24.1.50; pos-visible-in-window-p returns a false positive with bidi text
Date: Fri, 18 May 2012 11:03:52 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.1.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

> It's 270, yes.  But the rest is correct: if visible_p is set  in this
> case, it will never be reset with the current code.  My original code
> used
>       if (bottom_y >= it.last_visible_y
> which would have caught this case.
> Ari, can you please describe again what happens in this particular
> case on your machine, step by step, when you step with a debugger
> through the relevant fragment?

I sent this reply tonight:

The summary is that the case you are wondering about didn't have the bug
at all.

I tried to reproduce the bug in all three cases with emacs-24 revision
107933. The first case "emacs -Q" had the bug; "emacs -nw" had the bug;
"emacs -fn fixed" didn't have the bug.

Then I updated to revision 107934 (your patch). That fixed the "emacs
-nw" case. My tweak fixed the "emacs -Q" case.

Ari Roponen

reply via email to

[Prev in Thread] Current Thread [Next in Thread]