[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11795: 24.1.50; wdired: C-c C-c loses marks and positions of renamed
bug#11795: 24.1.50; wdired: C-c C-c loses marks and positions of renamed files
Wed, 27 Jun 2012 07:59:56 -0700
> >> This patch for wdired.el fixes the problem here (GNU Emacs 24.1.1).
> > But shouldn't Wdired respect the user's setting of option
> > `dired-keep-marker-rename'? IOW, shouldn't users be able to control
> > whether exiting wdired removes marks?
Looks OK to me.
A question is whether we should bother to invoke `dired-remember-marks' if
`dired-keep-marker-rename' is nil.
This patch is local to `wdired-finish-edit', which I think is intended to be
more or less atomic (a transaction), so I guess the answer is no (a user cannot
change the option value during `wdired-finish-edit').
Not calling `dired-remember-marks' if `dired-keep-marker-rename' is nil would
save a little time (not important), and I don't think we would lose anything
doing that. But it's a question.
BTW, I wonder if there isn't some part of `wdired-finish-edit' that should be in
an `unwind-protect'. Not thinking of anything in particular - just a feeling...