[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#11810: 24.1.50; `vc-diff' shrinks pre-existing window

From: Dmitry Gutov
Subject: bug#11810: 24.1.50; `vc-diff' shrinks pre-existing window
Date: Fri, 06 Jul 2012 03:19:37 +0400
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1

On 05.07.2012 13:53, martin rudalics wrote:
 > I tried it with just my patch applied, and it didn't work, because in
 > this case the stored height value was of already resized window:
 > `display-buffer-record-window' is called from `window--display-buffer',
 > and `display-buffer-use-some-window' calls `window--even-window-heights'
 > before `window--display-buffer'.

I think we could do

     (when window
       (window--display-buffer buffer window 'reuse)
       (window--even-window-heights window)))

in `display-buffer-use-some-window'.

That should work, but IMO `even-window-heights' behavior is just too surprising (with its conditions on window positions), so, if you don't mind, I'll open another bug with proposal to change its default value, presenting the above as alternative.

 > Until then, the issue is somewhat alleviated by the fact that you can
 > press 'z' or 'C-x k' instead of 'q', and both of these won't trigger
 > height restoration.

I'm more concerned with the fact that an application might reuse the
shrunk window via `display-buffer'.

In this case, unless the new buffer is the same as the one already displayed in the shrunk window, `display-buffer-record-window' will overwrite the 'quit-restore parameter, so I don't see what the problem scenario would be. Hadn't managed to reproduce one either.

 > If someone wants `shrink-window-if-...' to have no effect only in
 > `vc-diff', well, that's a different goal.

But that's probably what some people want.

I don't think we've seen a request exactly like that yet, but that would require a vc-prefixed variable.
Asynchronous `with-output-to-temp-buffer' proposal is better in that regard.

 >> Let's close this thread as follows: Remove the
 >> check in `quit-window' and add an integerp check for the third element.
 > Agreed.

Can you install it?  Else please post the patch and a ChangeLog entry.

Nope. Is unified diff okay?

window.el (quit-window): Always restore window height when it's saved in quit-restore parameter.

-- Dmitry

Attachment: quit-window.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]