[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#10299: Emacs doesn't handle Unicode characters in keyboard layout on
bug#10299: Emacs doesn't handle Unicode characters in keyboard layout on MS Windows
Tue, 7 Aug 2012 21:47:38 +0200
Your patch works fine for me on Windows XP. Unicode input outside the
system code page works fine and so does non-ASCII input that is
present in the current code page.
Since this seems much cleaner than the previous patch, it is
definitely the way to go.
I think the critical change was switching to both DefWindowProcW and
DispatchMessageW (at least that's what
leads you to believe).
I think I actually tried both those changes individually, but not both at once.
I'll test a patched build on Windows 7 tomorrow as well, sadly I don't
have access to anything running Windows 95.
Thanks for taking the time to look at this and test it.
On 7 August 2012 04:53, Eli Zaretskii <address@hidden> wrote:
>> Date: Mon, 6 Aug 2012 22:20:01 +0200
>> From: Joakim Hårsman <address@hidden>
>> Cc: address@hidden, address@hidden
>> Sorry for the late reply, I've been away on vacation.
> No sweat. Hope you had a good one.
>> The change to SetWindowTextW for frame titles was needed because
>> otherwise the frame title was cut short after the first character
>> (presumably because the window class name is a UCS-2 wide string and
>> the second byte therefore is null). This is exaclty the case they talk
>> about at your link.
>> If I change w32_set frame text to always call SetWindowText I get a
>> default frame title of "e". Changing DispatchMessage to use the wide
>> version when appropriate doesn't help either.
> I didn't see any problem with the frame title, with the patch I sent.
> I'm curious to hear if you will still see that problem.
>> I'll try your new patch tomorrow and get back with details on how it worked,
> Thank you.
bug#10299: Emacs doesn't handle Unicode characters in keyboard layout on MS Windows, Jason Rumney, 2012/08/07