[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#12169: [PATCH] Merge changes from upstream ruby-mode

From: Dmitry Gutov
Subject: bug#12169: [PATCH] Merge changes from upstream ruby-mode
Date: Sat, 11 Aug 2012 02:15:21 +0400
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:14.0) Gecko/20120713 Thunderbird/14.0

On 10.08.2012 19:54, Glenn Morris wrote:
> Are you also the upstream author?

Nope. Thanks for the reminder.

On 11.08.2012 0:28, Stefan Monnier wrote:
I've installed your patch, but please fix the ChangeLog authorship as
pointed out by Glenn (just include the changes in a subsequent patch).


Here's part 2, in which I'm skipping the next 3 commits:

For completeness, this later commit is directly related to the above 3:

I also don't include it, and we can see that the relevant test passes fine.

I also added that patch.  I presume that you're also trying to convince
Ruby's maintainers to undo those changes?

Not really, no. I will open an issue on Redmine since you asked, but nobody seems to be interested in pulling our changes back anyway, and as long as we're doing it in one direction, cherry-picking should be fine.

Here's a recent example: http://bugs.ruby-lang.org/issues/5140
A year-old bug, fixed in Emacs trunk, a user posted that information there with a patch 4 months ago, and... nothing.

Same as before: please provide a subsequent patch which corrects the
authorship attribution.

In my not-a-lawyer opinion, the example code in tests is not copyrightable, but okay, I mentioned the original author there too.


Attachment: ruby-upstream-3.diff
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]