[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#14130: 24.3.50; doc/help for advice and advised functions

From: Drew Adams
Subject: bug#14130: 24.3.50; doc/help for advice and advised functions
Date: Wed, 3 Apr 2013 08:13:57 -0700

Mostly an enhancement request, I guess, but partly a bug report.
1. (elisp) `Advising Functions'
Says "Note that enabling a piece of advice and activating advice for a
function are not the same thing."  But it does not say clearly what the
difference is.  It says only this:
a. A piece of advice can be "enabled"/"disabled".  It does not explain
what this means.
b. Advice takes effect only if both enabled and activated.
That's pretty incomplete.  The difference between these two things
(enabling, activating) is presumably important, and it is not made
clear.  It is not enough to tell users not to confuse the two, without
telling them clearly what the difference is.  Start with this question:
What is the purpose of each of them (enabling, activating)?
2. The definition of "forward advice", and the *important* fact that you
can advise a function without the function being defined yet, should be
moved from (elisp) `Defining Advice' to (elisp) `Advising Functions'.
It is not a detail concerning just the keyword `activate'.  (Note too
that there is zero use of or reference to "forward advice" in the
3. If these concepts apply also to the new advice facility written by
Stefan, then please keep this request in mind in that context: document
each of the various states of a piece of advice (enabled but not
activated etc.) etc.  (And where is the doc for that new facility?)
In GNU Emacs (i386-mingw-nt5.1.2600)
 of 2013-03-28 on ODIEONE
Bzr revision: 112173 address@hidden
Windowing system distributor `Microsoft Corp.', version 5.1.2600
Configured using:
 `configure --with-gcc (4.7) --no-opt --enable-checking --cflags
 -IC:/Devel/emacs/build/include --ldflags -LC:/Devel/emacs/build/lib'

reply via email to

[Prev in Thread] Current Thread [Next in Thread]