[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#14168: vc: [bzr] Properly limit revisions in 'vc-bzr-print-log'

From: Lluís Vilanova
Subject: bug#14168: vc: [bzr] Properly limit revisions in 'vc-bzr-print-log'
Date: Tue, 09 Apr 2013 21:47:35 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Bazaar's log command supports the "--forward" argument, which can be set in
bazaar's configuration file (beyond emacs' knowledge; e.g. using the alias
"log = log --forward"). This explains why the current implementation is breaking
the declared generic semantics (by assuming "--forward" is not being used).

This can be fixed by changing it into:

            (if (and start-revision (= limit 1))
                (list (format "-c%s" start-revision))
               (when start-revision (list (format "-r%s.." start-revision)))
               (when limit (list "-l" (format "%s" limit)))))

Note that this will still break if both are given and limit is different from 1
(in which case "-c" cannot be used), but this is explicitly forbidden by the
generic semantics.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]