[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#14180: PATCH Better fullscreen frame support on Windows

From: Erik Charlebois
Subject: bug#14180: PATCH Better fullscreen frame support on Windows
Date: Sat, 13 Apr 2013 21:23:16 -0400

I've rewritten the patch to preserve the maximized, fullwidth and fullheight functionality and fix them
on Windows 8; came out cleaner in the end too.

The FULLSCREEN_WAIT flag now gets cleared prior to using want_fullscreen (was a bug in the
existing implementation too I believe).

I've contacted the FSF clerk. Hopefully that can get cleared up soon.

2013-04-11  Erik Charlebois  <address@hidden>

* src/w32fns.c (w32_fullscreen_rect): New function to compute the
window rectangle for the given fullscreen mode.
(w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING
no longer tunes the window size.  This keeps the window's edges
flush with the screen and allows the taskbar to hide itself in
* src/w32term.c (w32fullscreen_hook): fullboth now shows without
window decorations and uses the entire screen.

On Sat, Apr 13, 2013 at 7:56 AM, Eli Zaretskii <address@hidden> wrote:
> Date: Sat, 13 Apr 2013 13:33:56 +0200
> From: Jan Djärv <address@hidden>
> CC: Erik Charlebois <address@hidden>, address@hidden
> 2013-04-13 12:09, Eli Zaretskii skrev:
> >
> > Jan, does the fullscreen functionality on X also maximizes the frame
> > to one of the monitors, when several monitors are available?  I don't
> > want to introduce differences in behavior here.
> >
> If there is a window manager running, we just tell the window manager to make
> Emacs fullscreen, so it is really up to the WM.  The window managers I worked
> with do maximize on one monitor only.
> When no WM is running we maximize to the whole display, i.e. all monitors.
> But that is more or less just for debugging when you want to see Emacs <->
> Xserver interractions without a WM getting in the way.  It is nothing a user
> ever encounters.

OK, thanks.  So I guess that part of Erik's patch is fine.

Attachment: W32_FULLSCREEN_2.txt
Description: Text document

reply via email to

[Prev in Thread] Current Thread [Next in Thread]