[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#14225: [PATCH] Winner mode fails to run mark activation and deactiva

From: Kelly Dean
Subject: bug#14225: [PATCH] Winner mode fails to run mark activation and deactivation hooks
Date: Wed, 17 Apr 2013 20:17:33 -0700 (PDT)

Using Emacs 24.3
emacs -Q
(winner-mode 1)
(add-hook 'deactivate-mark-hook (lambda () (setq cursor-type t)))
(add-hook 'activate-mark-hook (lambda () (setq cursor-type 'bar)))
C-x 2
C-c left

Notice that the cursor type is now a bar, not a block. It should be a block.
The attached winnerbug.patch fixes it.

BTW, by default in Emacs, when the region is active but empty, there's no 
visual indication of this status. Neither is there indication of the active 
region if point is one less than mark and blink-cursor-mode is off. Also, if 
point is greater than mark, the active region is highlighted, but the block 
cursor does an inverse-video highlight of the character following the region, 
which (speaking from experience) an Emacs newbie finds distracting, since it 
seems to indicate that that character is also part of the region. Setting the 
cursor type to bar when the region is active solves all those problems, and I 
recommend it as the default for Emacs.

Attachment: winnerbug.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]