bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#14317: 24.3.50; nadvice.el: named advices not upgradable


From: Michael Heerdegen
Subject: bug#14317: 24.3.50; nadvice.el: named advices not upgradable
Date: Fri, 03 May 2013 03:20:42 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Michael Heerdegen <address@hidden> writes:

> but as a user, I would suspect something like
>
> (defun advice--add-function (where ref function props)
>   (when (advice--member-p function (cdr (assq 'name props))
>                           (gv-deref ref))
>     (advice--remove-function .........))
>   (setf (gv-deref ref)
>         (advice--make where function (gv-deref ref) props)))
>
> i.e., replacing the old code, instead of doing nothing.

We should probably distinguish between named functions and
named advice.  I mean, it's probably stupid to remove and add
back an fboundp symbol - but you get the idea...


Regards,

Michael.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]