[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#14403: 24.3.50; [regression] Typing non-ascii characters on a non-GU

From: Stefan Monnier
Subject: bug#14403: 24.3.50; [regression] Typing non-ascii characters on a non-GUI MS-Windows session
Date: Wed, 22 May 2013 12:06:47 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

> Of course, we could always augment this condition:

>       if (!((FRAME_TERMCAP_P (frame) || FRAME_MSDOS_P (frame))
>           && (TERMINAL_KEYBOARD_CODING (terminal)->common_flags
>       return nextevt;         /* No decoding needed.  */

Before my change, the test was just

          (TERMINAL_KEYBOARD_CODING (terminal)->common_flags

but was done inside tty_read_avail_input.  AFAICT, tty_read_avail_input
is only used under POSIX ttys and MSDOS, hence this bug: FRAME_TERMCAP_P
is true for w32 non-GUI frames even though they don't use
tty_read_avail_input (they use w32_console_read_socket instead).

So a crude fix would be to check
"terminal->read_socket_hook == &tty_read_avail_input".

What would be a good test to cleanly distinguish posix ttys from w32


reply via email to

[Prev in Thread] Current Thread [Next in Thread]