bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#7899: Unsatisfactory interaction between shell-mode-hook and comint-


From: Pete Beardmore
Subject: bug#7899: Unsatisfactory interaction between shell-mode-hook and comint-read-input-ring
Date: Mon, 27 May 2013 08:44:25 +0100
User-agent: Internet Messaging Program (IMP) H5 (6.0.4)

[patches against bzr master attached (hopefully!)]

hi,

i believe this is a bug in comint-read-input-ring. shell-mode sets a buffer-local version of comint-read-input-size which is effectively ignored due to comint-read-input-ring's use of '(with-temp-buffer ...' . i've lost ~40000 line bash history on more than one occasion over the last several years and am elated to have finally pinned the problem on something

(very loosely) related to this issue is the question of why the default of 'comint-input-history-ignore' is set to anything at all? it's currently "^#", and therefore without having pro-actively made any changes to their emacs setup, a user's shell history (for instance) doesn't emerge unscathed from a trip through comint if it contains comments. if modifying this default touches too many other comint uses, perhaps an override in shell-mode.el?

cheers,
Pete

Attachment: txtR1AQDZLyqW.txt
Description: Text Data

Attachment: txtNaDDirW4P0.txt
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]