[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#14776: 24.3.50; [PATCH] parse-time-string performance
From: |
Lars Magne Ingebrigtsen |
Subject: |
bug#14776: 24.3.50; [PATCH] parse-time-string performance |
Date: |
Thu, 04 Jul 2013 23:15:11 +0200 |
User-agent: |
Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.3.50 (gnu/linux) |
Andreas Politz <politza@hochschule-trier.de> writes:
>> (benchmark-elapse (dotimes (i 10000) (parse-time-string "Thu, 04 Jul
>> 2013 20:06:00 +0200")))
>> => 1.120856647
>
> => 0.215108395
> ;-O
Wow, that's a pretty impressive speed-up. I do see one issue, though --
it doesn't parse 2-digit years? That's a requirement.
Anyway, with this large speed-up, I think we should definitely consider
swapping out the current parse-time code with your code. Could you
collect a bunch of Date headers from the wild and see whether the old
and new versions agree on them all?
> It looks that way, i.e. parse-time-string is pretty simple compared to
> that. But most Date header I've seen popping up in my mail seem to
> adhere to a strict rfc2822 format anyway, except for the occasional
> non-strict timezone.
Yes, mailers have gotten a lot better about adhering to the RFC2822 date
format the last decade.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog http://lars.ingebrigtsen.no/
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Andreas Politz, 2013/07/02
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Andreas Politz, 2013/07/02
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Glenn Morris, 2013/07/02
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Glenn Morris, 2013/07/02
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Andreas Politz, 2013/07/04
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Lars Magne Ingebrigtsen, 2013/07/04
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Andreas Politz, 2013/07/04
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Lars Magne Ingebrigtsen, 2013/07/04
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Andreas Politz, 2013/07/04
- bug#14776: 24.3.50; [PATCH] parse-time-string performance,
Lars Magne Ingebrigtsen <=
- Message not available
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Lars Ingebrigtsen, 2013/07/06
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Andreas Politz, 2013/07/06
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Lars Ingebrigtsen, 2013/07/06
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Andreas Politz, 2013/07/06
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Andreas Politz, 2013/07/06
- bug#14776: 24.3.50; [PATCH] parse-time-string performance, Lars Magne Ingebrigtsen, 2013/07/08
bug#14776: 24.3.50; [PATCH] parse-time-string performance, Andreas Politz, 2013/07/04