[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#14933: 24.3; [PATCH] bookmark-set default changed

From: Juri Linkov
Subject: bug#14933: 24.3; [PATCH] bookmark-set default changed
Date: Mon, 22 Jul 2013 23:00:05 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (x86_64-pc-linux-gnu)

> bookmark-set used to (at least in 24.2) use (car record) i.e. NAME as
> the default bookmark name when read from minibuffer. Now I am seeing
> buffer name instead. Is this change intentional? Any objection to
> applying the attached patch?

(car record) is used in `bookmark-set' when a specific
bookmark-make-record-function doesn't provide default values.

OTOH, (bookmark-buffer-name) in `bookmark-make-record' is intended
to do what `bookmark-insert-current-bookmark' used to do,
i.e. instead of typing a non-standard `C-u' binding,
now you can type `M-n' to insert the value of (bookmark-buffer-name)
to the minibuffer.

Your patch looks right, but please include
(bookmark-buffer-name) after (car record) as well,
i.e. you could use such code fragment in your patch:

     (delq nil (delete-dups (append (bookmark-prop-get record 'defaults)
                                    (list bookmark-current-bookmark
                                          (car record)

Then `M-n' will insert (car record) to the minibuffer,
and `M-n M-n' will insert (bookmark-buffer-name).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]