[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be call

From: Stefan Monnier
Subject: bug#14926: 24.3.50; Warning "`make-variable-buffer-local' should be called at toplevel"
Date: Fri, 16 Aug 2013 12:25:43 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

> The message still suggests that using make-variable-buffer-local other
> than at toplevel is erroneous.

Notice that the message is only emitted when the argument to the"
function is a constant.  I know of only one case where it is "not
erroneous" to have such a call not at top-level (from message.el):

   ;; FIXME: On XEmacs this causes problems since let-binding like:
   ;; (let ((message-options message-options)) ...)
   ;; as in `message-send' and `mml-preview' loses to buffer-local
   ;; variable initialization.
   (unless (featurep 'xemacs)
     (make-variable-buffer-local 'message-options))

So yes, I think in 99% of the cases, it's erroneous.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]