bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#3984: Fix for #3984


From: Ryan
Subject: bug#3984: Fix for #3984
Date: Fri, 13 Sep 2013 12:27:10 -0700
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:17.0) Gecko/20130801 Thunderbird/17.0.8

On Fri Sep 13 11:30:37 2013, Ryan wrote:
Looking at the code in trunk, I see that there is a special hook for
functions to decide which stack frames to skip over when looking for
call-interactively. I still think they should relax the test for
equality to "equal indirect-functions" instead of exactly the symbol
call-interactively.

Actually, I just noticed that in trunk, nadvice.el adds a function to "called-interactively-p-functions" to skip advice-related stack frames, but this works only for advice on the interactive function, not advice defined on call-interactively itself. Furthermore, from my limited testing it appears that the structure of the call stack for advised functions has changes significantly in trunk, making my code obsolete. The whole thing looks like a work in progress right now.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]