[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with deffa
bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface
Mon, 28 Oct 2013 22:29:57 -0400
Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/)
Barry OReilly wrote:
> Thanks, how is the attached revised patch?
Not quite what I had in mind (taking something that was a variable and
turning it into a face alias won't work right, will it?).
-(defvar semantic-idle-symbol-highlight-face 'region
- "Face used for highlighting local symbols.")
+ '((((class color) (background dark))
+ ;; Put this back to something closer to black later.
+ (:background "gray20"))
+ (((class color) (background light))
+ (:background "gray90")))
+ "Face used for highlighting local symbols."
+ :group 'semantic-faces)
As has been said:
(defface semantic-idle-symbol-highlight '((t (:inherit region))) ...)
Rather than the above, I meant:
"customize the face `semantic-idle-symbol-highlight' instead" "24.4" 'set)
Then these bits:
- region semantic-idle-symbol-highlight-face)
+ region 'semantic-idle-symbol-highlight)
are not necessary (or appropriate).
bug#15745: [PATCH] Define semantic-idle-symbol-highlight-face with defface, Stefan Monnier, 2013/10/28