[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookma
From: |
Kenjiro NAKAYAMA |
Subject: |
bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list. |
Date: |
Sat, 14 Dec 2013 23:18:27 +0900 |
User-agent: |
mu4e 0.9.9.6pre2; emacs 24.3.50.2 |
I changed bookmark-browse's behavior. This problem gets more serious, if
many many windows are opend...
* Reproduce the problem.
Step1. Open two windows, one is *eww* and the other is not eww.
Step2. In the *eww*, open the bookmark list with "B" key. (Now one is *eww*,
the other is *eww bookmarks*)
Step3. Select one URL in the bookmarklist(eww-bookmark-browse).
Step4. Now emacs window is only *eww*. <- #This is the problem.
Signed-off-by: Kenjiro NAKAYAMA <nakayamakenjiro@gmail.com>
* net/eww.el (eww-bookmark-browse): Don't hide windows with
browsing bookmark list.
---
lisp/net/eww.el | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 34c6728..c4e948b 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1179,10 +1179,8 @@ Differences in #targets are ignored."
(let ((bookmark (get-text-property (line-beginning-position) 'eww-bookmark)))
(unless bookmark
(error "No bookmark on the current line"))
- ;; We wish to leave this window, but if it's the only window here,
- ;; just let it remain.
- (ignore-errors
- (delete-window))
+ (eww-bookmark-quit)
+ (pop-to-buffer "*eww*")
(eww-browse-url (plist-get bookmark :url))))
(defun eww-next-bookmark ()
--
1.8.3.1
- bug#16144: 24.3.50; [PATCH] eww: Don't hide windows with browsing bookmark list.,
Kenjiro NAKAYAMA <=