[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#11474: Patch for Emacsclient --eval bug

From: Stefan Monnier
Subject: bug#11474: Patch for Emacsclient --eval bug
Date: Wed, 02 Apr 2014 10:57:56 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

[ Thanks for your patience.  ]

> emacsclient --alternate-editor "emacs" --eval "(make-frame-visible)"
> results in an Emacs with a buffer named "(make-frame-visible)".

Hmm... indeed, we have a problem here.  But I think the problem is that
it's very unclear what should be the right behavior.  IOW using both
"--alternate-editor" and "--eval" at the same time is "ill defined" and
the current behavior in that situation is particularly non-sensical.

> The patch provided below simply discards the Elisp arguments when
> emacsclient falls through to the alternate editor.  There may be better
> fixes, but this does the least harm while retaining compatibility.

Silently dropping arguments is not very polite, so I'm not really happy
with your solution.  I think the "right" behavior would be to call the
alternate editor while preserving most arguments; IOW the right fix
in this case would be to add a "--eval" argument, so that your
alternate_editor can decide whether to drop args when it gets an
"--eval" or to prepend all other args with a "--eval=" (or do whatever
else it fancies).



reply via email to

[Prev in Thread] Current Thread [Next in Thread]