[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#17320:[pretest]; bug-sourcing design-flaw

From: Andreas Röhler
Subject: bug#17320:[pretest]; bug-sourcing design-flaw
Date: Wed, 23 Apr 2014 09:43:38 +0200
User-agent: Mozilla/5.0 (X11; Linux i686; rv:24.0) Gecko/20100101 Thunderbird/24.2.0

When looking for bug #17247

noticed the following

lisp.el, line 374:

    ;; When comparing point against pos, we want to consider that if
    ;; point was right after the end of the function, it's still
    ;; considered as "in that function".
    ;; E.g. `eval-defun' from right after the last close-paren.
    (unless (bolp)
      (skip-chars-forward " \t")
      (if (looking-at "\\s<\\|\n")
          (forward-line 1)))


A core function should not do that kind of provisions.
Employing forward-line, point might end up at the beginning of valid code, not 
at the end.
Thus beginning and end of functions are in risk being mixed.

Suggest to drop that and let `eval-defun' etc. make provisions at their needs.



GNU Emacs (i686-pc-linux-gnu, GTK+ Version 2.24.10) of 2014-04-21

reply via email to

[Prev in Thread] Current Thread [Next in Thread]