[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#18204: 24.4.50; `ediff-file-compressed-p'

From: Drew Adams
Subject: bug#18204: 24.4.50; `ediff-file-compressed-p'
Date: Tue, 5 Aug 2014 14:49:29 -0700 (PDT)

Could be improved from this:

(defun ediff-file-compressed-p (file)
  (condition-case nil
      (require 'jka-compr)
  (if (featurep 'jka-compr)
      (string-match (jka-compr-build-file-regexp) file)))

to this:

(defun ediff-file-compressed-p (file)
  (and (require 'jka-compr nil t)
       (string-match-p (jka-compr-build-file-regexp) file)))

Or just remove it altogether - it is used only once.

(Or provide it as a general function, outside `ediff-util'.)

In GNU Emacs (i686-pc-mingw32)
 of 2014-06-28 on ODIEONE
Bzr revision: 117431 address@hidden
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
 `configure --prefix=/c/Devel/emacs/snapshot/trunk
 --enable-checking=yes,glyphs 'CFLAGS=-O0 -g3'
 LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1

reply via email to

[Prev in Thread] Current Thread [Next in Thread]