[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#18351: [Alan Schmitt] Small patch for gnus nnimap.el
From: |
Stefan Monnier |
Subject: |
bug#18351: [Alan Schmitt] Small patch for gnus nnimap.el |
Date: |
Thu, 28 Aug 2014 21:59:31 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) |
> I posted this on gnus.general a couple weeks ago, but nobody
> replied. I'm thus wondering if emacs.devel might be a better place to
> send gnus patches. If not, could you please direct me to the correct place?
Both places are good choices.
> The problem with this function is that the list of deleted articles is
> reversed in every case, but it should only be reversed in the last case
> (when it was created considering each article in turn and pushing it
> onto the list, thus creating it in reverse). Attached is a patch fixing
> this.
The analysis looks good, and so does the patch.
> If you agree with this analysis, could you please apply this patch?
I can apply the patch, but since I'm not familiar with this code,
I'd like to hear some comment from one of the Gnus guys.
> I have a question about the code above. Why do the first two cases of
> the cond return a 't' at the end?
Very good question. Probably hysterical raisins?
Stefan