bug#18022: 24.3; Emacs hard locks when attempting to do a replacement with ^M in it.

[Alan Mackenzie]

Hello, Stefan.

Ping?

On Wed, Jul 23, 2014 at 06:41:46PM +0000, Alan Mackenzie wrote:
> Hi, everybody!

> On Sat, Jul 19, 2014 at 08:33:10PM +0000, Alan Mackenzie wrote:
> > Hello, Stefan, Marty and Eli.

> > Looking at back_comment, just after the main loop at L+205, we have the
> > code which restores point and the current syntax table:

> >   if (comstart_pos == 0)
> >     {
> >       from = comment_end;
> >       from_byte = comment_end_byte;
> > =>    UPDATE_SYNTAX_TABLE_FORWARD (comment_end - 1);
> >     }

> > It seems to me that that " - 1" is what is causing the syntax table to be
> > restored to the value for ">", and shouldn't be there.  Stefan, am I
> > right?

> I should have included a patch.  Sorry!  Here it is, in case anybody
> didn't feel like working through the textual description.  I think this
> fixes the bug, if it's correct.


> === modified file 'src/syntax.c'
> *** src/syntax.c      2014-07-09 23:39:58 +0000
> --- src/syntax.c      2014-07-23 18:26:45 +0000
> ***************
> *** 825,831 ****
>       {
>         from = comment_end;
>         from_byte = comment_end_byte;
> !       UPDATE_SYNTAX_TABLE_FORWARD (comment_end - 1);
>       }
>     /* If comstart_pos is set and we get here (ie. didn't jump to `lossage'
>        or `done'), then we've found the beginning of the non-nested comment.  
> */
> --- 825,831 ----
>       {
>         from = comment_end;
>         from_byte = comment_end_byte;
> !       UPDATE_SYNTAX_TABLE_FORWARD (comment_end);
>       }
>     /* If comstart_pos is set and we get here (ie. didn't jump to `lossage'
>        or `done'), then we've found the beginning of the non-nested comment.  
> */


-- 
Alan Mackenzie (Nuremberg, Germany).