[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#18550: eww-history-browse may end up calling eww-restore-history in
From: |
Lars Magne Ingebrigtsen |
Subject: |
bug#18550: eww-history-browse may end up calling eww-restore-history in an arbitrary buffer |
Date: |
Wed, 19 Nov 2014 18:25:57 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Ivan Shmakov <ivan@siamics.net> writes:
> I see no reason to abuse quit-window for what’s essentially
> switching to a buffer to edit one. That is: the
> eww-restore-history call right after quit-window edits the
> /current/ buffer. Thus, it indeed makes sense to explicitly use
> set-buffer before that. (Or to wrap the call in
> with-current-buffer, anyway.)
>
> Moreover, vc.el already uses a dedicated buffer-local variable
> for a similar purpose, and so does rcirc.el, and perhaps a few
> more modes out there.
I think you're arguing against yourself here. If this is such a common
thing to do, then something in this setup should provide this
functionality, so that all these modes don't have to implement it again
and again.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no