[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#15880: Compute C declarations for DEFSYMs automatically.

From: Paul Eggert
Subject: bug#15880: Compute C declarations for DEFSYMs automatically.
Date: Fri, 09 Jan 2015 08:33:53 -0800
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0

Eli Zaretskii wrote:
Could we instead just keep the previous semantics of XIL and XLI,
please?  They are used in a few places outside lisp.h, so now all of
those places need to be audited and most probably changed.  Why isn't
it better to change the implementation of just 2 macros instead?

XIL and XLI haven't changed, and have the same semantics as before: they convert between Lisp_Object and EMACS_INT without altering the bits (i.e., they are no-ops at the machine level). I expect it's better to keep them no-ops, for efficiency in the kernel of the Emacs Lisp interpreter.

I audited all the places XIL and XLI are used, and the uses in non-w32 code are all fine. I don't know the w32 code, but most likely some or all of its uses need to be changed. I moved the new conversion operations to lisp.h (installed on master) and wrote the attached untested patch for the w32 code.

Attachment: 0001-Fix-pointer-to-integer-conversion-in-w32-code.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]