[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#19493: [PATCH] Fix trailing ... for outline-toggle-children

From: Dmitry Gutov
Subject: bug#19493: [PATCH] Fix trailing ... for outline-toggle-children
Date: Fri, 16 Jan 2015 16:32:34 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:33.0) Gecko/20100101 Thunderbird/33.0

Hi! This piece of code doesn't make sense to me:

On 01/03/2015 03:04 AM, Oleh Krehel wrote:

-  (if (and (bolp) (or outline-blank-line (eobp)) (not (bobp)))
+  (if (and (bolp) (or outline-blank-line (eobp))
+           (not (bobp)) (not (eobp)))

The second condition already checks for `eobp', so apparently the function is supposed to handle the end-of-buffer case.

If that was an error in someone's thinking, the patch should correct that as well. But maybe the fix should do something in the caller instead.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]