[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#6130: 23.1; artist-mode spray-can malfunction
From: |
Stefan Monnier |
Subject: |
bug#6130: 23.1; artist-mode spray-can malfunction |
Date: |
Thu, 22 Jan 2015 12:02:09 -0500 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
>> The Right Thing to do, AFAICT, is for posnp to return non-nil also when
>> the `car' is a frame.
> If the caller of `posnp' is not prepared to deal with a frame but used
> `posnp' to check that the position is "valid", it currently will not
> fail.
Yes, I understand. We can't always Do The Right Thing. But that's
still The Right Thing.
> `posnp'. So at least for Emacs 24.5 I would rather not change the
> current behavior.
That's for sure, yes.
> I would change it for Emacs 25.
We violently agree.
>> For posn-window, the question is more tricky. I don't think it should
>> ever return a frame, since its name makes it clear it returns a window.
> Agreed. But `posn-window' is just a mnemonic for "get me the first
> element of a position".
Could you take a look at the existing callers to see how they would
react to receiving nil (instead of a frame), or a frame (as now), or an
error (instead of a frame)?
>> So we should either make it return nil when the car is a frame, or
>> signal an error, or return the frame's selected-window,
> The latter would be certainly wrong. We are NOT in that window.
Indeed.
>> and/or deprecate it (in favor of a new posn-window-or-frame).
> That's what I had in mind.
But that only makes sense if most callers of posn-window can (or would
like to) also handle a frame.
Stefan
- bug#6130: 23.1; artist-mode spray-can malfunction, Daniel Koning, 2015/01/17
- bug#6130: 23.1; artist-mode spray-can malfunction, martin rudalics, 2015/01/17
- bug#6130: 23.1; artist-mode spray-can malfunction, Daniel Koning, 2015/01/18
- bug#6130: 23.1; artist-mode spray-can malfunction, martin rudalics, 2015/01/18
- bug#6130: 23.1; artist-mode spray-can malfunction, Daniel Koning, 2015/01/20
- bug#6130: 23.1; artist-mode spray-can malfunction, martin rudalics, 2015/01/21
- bug#6130: 23.1; artist-mode spray-can malfunction, Stefan Monnier, 2015/01/21
- bug#6130: 23.1; artist-mode spray-can malfunction, martin rudalics, 2015/01/21
- bug#6130: 23.1; artist-mode spray-can malfunction,
Stefan Monnier <=
- bug#6130: 23.1; artist-mode spray-can malfunction, martin rudalics, 2015/01/22
- bug#6130: 23.1; artist-mode spray-can malfunction, Stefan Monnier, 2015/01/22
- bug#6130: 23.1; artist-mode spray-can malfunction, martin rudalics, 2015/01/23
- bug#6130: 23.1; artist-mode spray-can malfunction, Eli Zaretskii, 2015/01/23
- bug#6130: 23.1; artist-mode spray-can malfunction, martin rudalics, 2015/01/23
- bug#6130: 23.1; artist-mode spray-can malfunction, Stefan Monnier, 2015/01/23
- bug#6130: 23.1; artist-mode spray-can malfunction, Eli Zaretskii, 2015/01/23
- bug#6130: 23.1; artist-mode spray-can malfunction, Daniel Koning, 2015/01/23
- bug#6130: 23.1; artist-mode spray-can malfunction, Eli Zaretskii, 2015/01/24
- bug#6130: 23.1; artist-mode spray-can malfunction, martin rudalics, 2015/01/24