[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20118: 25.0.50; tramp-test29-vc-registered aborts on Cygwin
From: |
Michael Albinus |
Subject: |
bug#20118: 25.0.50; tramp-test29-vc-registered aborts on Cygwin |
Date: |
Tue, 17 Mar 2015 11:36:41 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) |
Ken Brown <kbrown@cornell.edu> writes:
>>> The outward symptom is almost identical to that of Bug#20117, but I
>>> don't know if the present bug is related, because it's been happening
>>> for as long as I can remember; I just never got around to reporting it.
>>>
>>> Test tramp-test29-vc-registered aborted with non-local exit
>>> ABORTED 30/41 tramp-test29-vc-registered
>>
>> Please instrument it similar to the recipe in bug#20117.
>
> Output attached.
Well, this bug is different from Bug#20117. A shell function Tramp sends
to the remote host contains some lines with leading TABs. Your bash tries
to expand them.
The following patch shall fix this.
--8<---------------cut here---------------start------------->8---
*** /home/albinus/src/tramp/lisp/tramp-sh.el.~master~ 2015-03-17
11:25:13.857882111 +0100
--- /home/albinus/src/tramp/lisp/tramp-sh.el 2015-03-17 11:24:45.233315481
+0100
***************
*** 3725,3730 ****
--- 3725,3734 ----
(tramp-get-connection-process vec) "scripts" nil)))
(unless (member name scripts)
(with-tramp-progress-reporter vec 5 (format "Sending script `%s'" name)
+ ;; In bash, leading TABs like in `tramp-vc-registered-read-file-names'
+ ;; could result in unwanted command expansion. Avoid this.
+ (setq script (tramp-compat-replace-regexp-in-string
+ (make-string 1 ?\t) (make-string 8 ? ) script))
;; The script could contain a call of Perl. This is masked with `%s'.
(when (and (string-match "%s" script)
(not (tramp-get-remote-perl vec)))
--8<---------------cut here---------------end--------------->8---
> Ken
Best regards, Michael.