[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded a
From: |
Ivan Shmakov |
Subject: |
bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data |
Date: |
Sat, 11 Apr 2015 18:07:13 +0000 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) |
>>>>> Steve Purcell <steve@sanityinc.com> writes:
> --- a/lisp/emacs-lisp/package.el
> +++ b/lisp/emacs-lisp/package.el
> @@ -1279,12 +1279,13 @@ defun package--read-archive-file (file)
> (let ((filename (expand-file-name file package-user-dir)))
> (when (file-exists-p filename)
> (with-temp-buffer
> - (insert-file-contents-literally filename)
> - (let ((contents (read (current-buffer))))
> - (if (> (car contents) package-archive-version)
> - (error "Package archive version %d is higher than %d"
> - (car contents) package-archive-version))
> - (cdr contents))))))
> + (let ((coding-system-for-read 'utf-8))
> + (insert-file-contents filename)
As insert-file-contents may imply a whole lot of additional
processing beyond decoding UTF-8, I’d rather use an explicit
decode-coding-region here, like (untested):
(with-temp-buffer
(insert-file-contents-literally filename)
+ (decode-coding-region (point-min) (point-max) 'utf-8)
(let ((contents (read (current-buffer))))
…))
> + (let ((contents (read (current-buffer))))
> + (if (> (car contents) package-archive-version)
> + (error "Package archive version %d is higher than %d"
> + (car contents) package-archive-version))
> + (cdr contents)))))))
>
> (defun package-read-archive-contents (archive)
> "Re-read archive contents for ARCHIVE.
--
FSF associate member #7257 http://boycottsystemd.org/ … 3013 B6A0 230E 334A
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data, Steve Purcell, 2015/04/11
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data, Eli Zaretskii, 2015/04/11
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data,
Ivan Shmakov <=
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data, Eli Zaretskii, 2015/04/11
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data, Ivan Shmakov, 2015/04/11
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data, Eli Zaretskii, 2015/04/11
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data, Artur Malabarba, 2015/04/13
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data, Stefan Monnier, 2015/04/13
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data, Steve Purcell, 2015/04/13
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data, Artur Malabarba, 2015/04/19
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data, Steve Purcell, 2015/04/19
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data, Eli Zaretskii, 2015/04/19
- bug#20231: 25.0.50; package.el mangles non-ascii content in downloaded archive-contents data, Artur Malabarba, 2015/04/19