bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#20677: tooltips generate garbage


From: Angelo Graziosi
Subject: bug#20677: tooltips generate garbage
Date: Tue, 02 Jun 2015 19:04:39 +0200
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0



Il 02/06/2015 18:02, Eli Zaretskii ha scritto:

IOW, reverting 7927a4 seems to cause us call x_clear_area with a wrong
argument list.  How does this even compile?  What am I missing?

I tried this in gtkutil.c

+          x_clear_area (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f),
+                        oldx, oldy, oldw, oldh);
-          x_clear_area (f, oldx, oldy, oldw, oldh);

and it didn't compile (wrong number of arguments)...

I don't understand this:


diff --git a/src/xfns.c b/src/xfns.c
index 5ac58e9..16a568e 100644
--- a/src/xfns.c
+++ b/src/xfns.c
@@ -1084,7 +1084,8 @@ struct x_display_info *
          y = FRAME_TOP_MARGIN_HEIGHT (f);

          block_input ();
-         x_clear_area (f, 0, y, width, height);
+         x_clear_area (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f),
+                       0, y, width, height);
          unblock_input ();
        }

@@ -1095,8 +1094,7 @@ struct x_display_info *
          height = nlines * FRAME_LINE_HEIGHT (f) - y;

          block_input ();
-         x_clear_area (f, 0, y, width, height);
+         x_clear_area (FRAME_X_DISPLAY (f), FRAME_X_WINDOW (f),
+                       0, y, width, height);
          unblock_input ();
        }


remember that

  79bbe53a991007036ce9bcf897a4ce1371f516ea  2015-05-23 09:21:27 (GMT)

works as expected, while

 ee14727ce033bae3bc11af35e7843604e5a5e635   2015-05-23 10:27:56 (GMT)

shows the issue, and ee14727ce033bae3bc1... has already xfns.c with that above (+) code..






reply via email to

[Prev in Thread] Current Thread [Next in Thread]