bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#20728: 25.0.50; grep and grep-find templates should have a place hol


From: Dmitry Gutov
Subject: bug#20728: 25.0.50; grep and grep-find templates should have a place holder for the --color argument
Date: Thu, 4 Jun 2015 18:18:55 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0

On 06/04/2015 06:01 PM, Eli Zaretskii wrote:

Why not allow users of grep.el bind grep-highlight-matches to
whatever, including nil, and make grep.el obey that?

That would be the effect. rgrep (and zrgrep) call grep-expand-template to create the command to invoke.

Using a template
for such a simple job sounds like over-engineering to me.  I can
understand why the template is used in find-grep and related commands:
the 'find' or 'xargs' command line is somewhat tricky.

find-grep is what this issue is about.

But there's no
such problem with 'grep', so I'm unsure why we want to use a template
there, let alone have a placeholder for that switch in the template.

The behavior of M-x grep is beyond my concern. But how would you implement automatic support for that variable in it, if not using a template?





reply via email to

[Prev in Thread] Current Thread [Next in Thread]