[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#21167: 24.5; tags-search should ignore buffer restriction

From: phs
Subject: bug#21167: 24.5; tags-search should ignore buffer restriction
Date: Fri, 31 Jul 2015 11:43:39 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0

Description: tags-search when going through all files listed in the current tags table, tags-search searches inside existing buffers for files that are currently visited (this is where the latest version can be found).

But when the visiting buffer has been restricted by a narrow-to-region, tags-search will not look outside the narrowed-to scope.

I call this a bug. E.g., it can cause a global renaming of variables miss some occurrences. It seems that a minimal fix is for tags-search to warn the user that the buffer has been narrowed and offer to widen for the search (and maybe reinstall the restriction after the search???).

I looked at the source code. It appears that the problem is located within function next-file (in progmodes/etags.el). When it is found that there already is a buffer visiting the file to be searched for tags, next-file just uses it without checking for restrictions.

BTW, I don't understand why next-file passes the novisit flag to find-file?

Philippe SCHNOEBELEN,                             www.lsv.ens-cachan.fr/~phs
LSV, CNRS UMR 8643 & ENS de Cachan                    Tel: (+33/0) 147 407 530
"Algebraic symbols are used when you do not know what you are talking about"

reply via email to

[Prev in Thread] Current Thread [Next in Thread]