bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#21383: Static revisions in vc-working-revision


From: Stefan Monnier
Subject: bug#21383: Static revisions in vc-working-revision
Date: Mon, 31 Aug 2015 23:55:22 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux)

> -(defun vc-git-working-revision (file)
> +(defun vc-git-working-revision (_file)

VC was originally designed so as to separate the VC data from the
buffers, so the `file' argument was absolutely indispensable (you
can't/shouldn't rely on things like the current-buffer's default-directory).

I think nowadays the design has been changed enough that indeed the
`file' arg can be dispensed with.

The rest looks OK to me,


        Stefan





reply via email to

[Prev in Thread] Current Thread [Next in Thread]