bug#21435: 25.0.50; file-notify has problems after renames

[Michael Albinus]

Tassilo Horn <tsdh@gnu.org> writes:

>> But then Tassilo's "renames always seem to be reported twice" is
>> inaccurate: this should only happen when a file is moved to another
>> directory.
>
> See my other mail: the test if the source/target are different were done
> by testing if the descriptors are not `eq' but since inotify descriptors
> are conses, that test returned nil even though they were structurally
> equal.

Thanks for fixing this. I always had in mind that
`file-notify--descriptor' returns the same object, and maybe it did even
so in the past, but now it composes the cons itself. So we must test for
`equal', indeed.

>>> PS: Tassilo, you write great test cases. Do you want to contribute to
>>> test/automated/file-notify-tests.el?
>
> Yes, but right now I can't because all these corner cases like the ones
> from my last two reports are largely undocumented so I don't know what
> to assert.  I myself don't have a strong opinion on the behavior of
> file-notify as long as it's consistent across the different
> `file-notify--library' possibilities (at least mostly, e.g., I can live
> with created/deleted events in place of renamed in case the backend
> doesn't support this) and the documentation is a bit more definite.

Even the straigt forward cases are not covered well in
file-notify-tests.el. There is a test whether events arrive, but the
nature of the events is not asserted.

You could try with what you expect, at least for inotify, and Eli and I
could check then for the gfilenotify and w32notify cases. If we have the
same results, fine; if we have different results it would be a good
chance for us to harmonize.

And starting with inotify is also good because this is the library used
on hydra. We do not want to make Glenn sad because of failed tests.

>>> PPS: Forgive me slow progress; I'm still suffering from health
>>> problems.
>>
>> Wish you to recover quickly.
>
> Ditto!

Won't happen, unfortunately. It still takes months.

> Bye,
> Tassilo

Best regards, Michael.