bug#21415: 25.0.50; Emacs Trunk -- pixelwise width/height for x-create-frame

[Anders Lindgren]

Hi,

> I will take a look at fringe-related problems next.

That inversion effect is pretty distracting, indeed.

I have attached a fix for the fringe issue. The images were reversed, the background was not transparent (which the rendering code assumed it was), and finally, all images were mirror flipped left-to-right...

I have attached a patch for this, please try it out. If possible, try to check if this causes some other image-related problems which I haven't thought of.

(I will clean up the trace code before I commit it.)

> I might be able to take
> a look at this after that.
>
>
> I just pushed the toolbar fix and the startup crash fix.

Fine.  Keith, can you test it?  Just turn off/on the tool bar once with
a normal and a maximized frame.

Eventually it would be to nice to have adding/removing the tool bar obey
‘frame-inhibit-implied-resize’ (it currently works OK for the maximized
frame so the fix shouldn't be too hard).

I don't think it really worked for fullheight frames. When enabling the tool bar in a maximized frame it looked OK at first glance. However, below the screen, the window stretched out about three text lines, but due to the bug Keith reported, the text grid was restricted with the same amount. The effect was that it only looked like it worked.

Now, when enabling tool-bar mode in a fullheight frames, after Keiths bug was fixed, the frame stretches below the screen. It's a bit unfortunate, but it will be a lot of work to do anything about it -- given how the tool bar is currently implemented.

Keith wrote:

> The first time I turned off the toolbar from a maximized frame, the frame shrunk a little.  When I turned the toolbar back on again, the frame did not return to a maximized position -- i.e., it remained a few pixels shy of full-screen in terms of height.

I can see the same effect here. I have only tried this with a fullheight frame, in which case it worked. I will take a look at it and try to figure out what the difference between the fullheight and maximized cases.

    -- Anders

Ps. I will be away over the weekend -- hopefully I will be able to answer mail but not do any Emacs core work.

 

emacs-commit-messages-fringe.txt
Description: Text document

fringe.diff
Description: Text document