[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22019: 25.0.50; Bad comment in `character-fold-to-regexp'
From: |
Drew Adams |
Subject: |
bug#22019: 25.0.50; Bad comment in `character-fold-to-regexp' |
Date: |
Thu, 26 Nov 2015 15:03:36 -0800 (PST) |
This part of an explanatory comment is inadequate and inappropriate:
;; See commit message for a longer description.
What commit message? The source code should contain the description.
If a VC commit message happens to also contain the description, so
much the better for it. But that doesn't help a reader of the code.
This comment is intended to make clear what the design/intention is.
Readers of the source code deserve the additional design information
as much as maintainers who might bother to access the relevant commit.
In GNU Emacs 25.0.50.1 (i686-pc-mingw32)
of 2015-11-12
Bzr revision: 6e5186e8a7ccfb9b8fb35b5f4f0371e4f4a68162
Windowing system distributor `Microsoft Corp.', version 6.1.7601
Configured using:
`configure --prefix=/c/Devel/emacs/snapshot/trunk
--enable-checking=yes,glyphs --enable-check-lisp-object-type
--without-compress-install --with-wide-int 'CFLAGS=-O0 -ggdb3'
LDFLAGS=-Lc:/Devel/emacs/lib 'CPPFLAGS=-DGC_MCHECK=1
-Ic:/Devel/emacs/include''
- bug#22019: 25.0.50; Bad comment in `character-fold-to-regexp',
Drew Adams <=