[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stop

From: Vasilij Schneidermann
Subject: bug#22114: 24.5; [PATCH] Allow profiler.el to display reports after stopping
Date: Mon, 14 Dec 2015 09:28:36 +0100
User-agent: Mutt/1.5.24 (2015-08-30)

> Your testing was too superficial.  IIRC The problem to which the comments
> refer can only show up if you modify the hash-table.
> The problem is corner-case, but real.  And there's no reason not to plug
> that hole.

I see, I can trigger this by removing a key from the log.  I haven't
thought about that possibility yet, because, why would you do that?
Nevertheless, if I'd want to fix this, I'd just need to use
`copy-hash-table` on the log and return its result?

> E.g. I don't think you need to the C-side changes to get the Elisp
> side to provide the functionality you're looking for.

I've initially provided an elisp-only patch that works around the
profiler resetting the log with an extra level of indirection:  Before
stopping the profiler or accessing the log while it's still running, the
log is saved to a variable, the other code just accesses that variable
instead of retrieving the log directly.  I'm not really happy with it
though as it does need more code than the other variant and does only
fix the UI aspect of viewing a report after the profiler has been
stopped.  In case you haven't seen it yet, I'll attach it to this

Attachment: 0001-Allow-for-retrieving-profiler-logs-after-stopping.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]