[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#22323: Font fallback causes inconsistent stacking of faces in overla
bug#22323: Font fallback causes inconsistent stacking of faces in overlays with invisible property
Fri, 08 Jan 2016 12:22:52 +0200
> Cc: address@hidden
> From: Clément Pit--Claudel <address@hidden>
> Date: Thu, 7 Jan 2016 20:19:25 -0500
> > Here's a suggestion: ignore the face of the invisible text altogether,
> > and instead always use the face of the last visible character. The
> > patch to do that is below; it fixes all of your test cases. But since
> > you would like to see the face of the invisible text show through, I'm
> > not sure you will like it...
> > WDYT?
> I like it :) I find it much more consistent that what we currently have. Plus,
> has a desirable property that you pointed out and that I agree with, that the
> properties of the invisible text do not affect the display of the ellipsis.
> current implementation doesn't have that property (adding a face to a hidden
> character will cause the ellipsis to change to the default face), so I think
> it's a net gain.
Thanks, I pushed it, and I'm marking these 2 bugs as done.
> (In fact, I'm even a bit surprised that it handles the selection and font
> fallback cases properly. It's great that it does though; but did I apply the
> patch incorrectly?)
Yes, you applied correctly. The default ellipsis uses ASCII
characters, so I think the fallback font doesn't affect them.