[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#23075: 24.5; vc-git-command should use coding-system-for-read
From: |
Óscar Fuentes |
Subject: |
bug#23075: 24.5; vc-git-command should use coding-system-for-read |
Date: |
Mon, 21 Mar 2016 17:54:28 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.0.92 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> If you have files in your repositories, that are in different coding
>> system from vc-git-commits-coding-system, vc-diff would still show diffs
>> for them in vc-git-commits-coding-system.
>>
>> This is unnecessary, since vc-diff-internal already decides what coding
>> system to use based on the first file and then sets
>> coding-system-for-read accordingly.
>>
>> The fix is to change vc-git-command to use coding-system-for-read
>> whenever it's bound.
>
> Please show a recipe for reproducing this problem with a recent Git
> version and preferably with the latest pretest of Emacs 25.1. Please
> include any files necessary for the reproduction. Before we dive into
> this tricky issue, I'd like to be sure the problem still exists (since
> more than a year has passed since your original reports).
>
> Also, this is specific to MS-Windows, right?
Maybe this is related: on a Kubuntu 15.08 box with a 2 week old emacs
25.0.92.2 and git 2.5.0, if I visit etc/HELLO (on a Emacs checkout) and
do `C-x v l' and then, on the *vc-change-log* buffer, put the cursor on
the last commit (etc/HELLO: Add Armenian and Mongolian greetings.) and
press `d', the ensuing *vc-diff* buffer contains mostly garbage.
- bug#23075: 24.5; vc-git-command should use coding-system-for-read, Nikolay Kudryavtsev, 2016/03/21
- bug#23075: 24.5; vc-git-command should use coding-system-for-read, Eli Zaretskii, 2016/03/21
- bug#23075: 24.5; vc-git-command should use coding-system-for-read,
Óscar Fuentes <=
- bug#23075: 24.5; vc-git-command should use coding-system-for-read, Eli Zaretskii, 2016/03/21
- bug#23075: 24.5; vc-git-command should use coding-system-for-read, Andreas Schwab, 2016/03/21
- bug#23075: 24.5; vc-git-command should use coding-system-for-read, Óscar Fuentes, 2016/03/21
- bug#23075: 24.5; vc-git-command should use coding-system-for-read, Eli Zaretskii, 2016/03/21
- bug#23075: 24.5; vc-git-command should use coding-system-for-read, Óscar Fuentes, 2016/03/21
- bug#23075: 24.5; vc-git-command should use coding-system-for-read, Eli Zaretskii, 2016/03/21
- bug#23075: 24.5; vc-git-command should use coding-system-for-read, Nikolay Kudryavtsev, 2016/03/21
- bug#23075: 24.5; vc-git-command should use coding-system-for-read, Eli Zaretskii, 2016/03/21
- bug#23075: 24.5; vc-git-command should use coding-system-for-read, Nikolay Kudryavtsev, 2016/03/21