bug#15909: 24.3.50; please fix `read-face-name' brain-dead PROMPT handling

[Lars Ingebrigtsen]

Drew Adams <drew.adams@oracle.com> writes:

> In Emacs 20, the PROMPT arg was just passed to `completing-read'.  So
> you used ": " at the end.  As usual in Emacs.  Simple.  Sure.  No
> nonsense.
>
> In Emacs 22, `read-face-name' decided to become "smart": It required
> callers NOT to end the PROMPT with a space.  Dumb.
>
> In Emacs 24, `read-face-name' decided to become even "smarter": It
> requires callers NOT to end the PROMPT with EITHER a space or a colon.
> It systematically adds ": " to PROMPT.  Dumber.
>
> This is silly.  It means that any 3rd-party code that passes a prompt to
> `read-face-name' has to fiddle with it to get the desired result for
> different Emacs versions.  To what end?  What good is accomplished by
> this silliness?

I've now pushed a fix for this to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no