[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#11028: 24.0.94; bad lighter and menus for `text-scale-mode'
From: |
Lars Ingebrigtsen |
Subject: |
bug#11028: 24.0.94; bad lighter and menus for `text-scale-mode' |
Date: |
Sun, 01 May 2016 22:22:20 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) |
Eli Zaretskii <eliz@gnu.org> writes:
>> From: Lars Ingebrigtsen <larsi@gnus.org>
>> Date: Sun, 01 May 2016 21:46:39 +0200
>> Cc: 11028@debbugs.gnu.org
>>
>> "Drew Adams" <drew.adams@oracle.com> writes:
>>
>> > -1
>> > -------------------
>> > Turn Off minor mode
>> > Help for minor mode
>>
>> [...]
>> (let* ((minor-mode (lookup-minor-mode-from-indicator indicator))
>> (mm-fun (or (get minor-mode :minor-mode-function) minor-mode)))
>>
>> Wow, that's a roundabout way of doing it... Anyway, we then have the
>> mode symbol... What about using a pretty version of the mode symbol as
>> the menu header? That would be "Text Scale Mode" in this case.
>
> What menu header? Drew was complaining about the tooltip, not the
> menu. When you actually click on the lighter, the pop-up menu does
> have a header that shows the mode name.
>
> So what are you trying to do here?
The thing with the "+1" at the top is a menu:
(setq menu
(if menu
(mouse-menu-non-singleton menu)
(if (fboundp mm-fun) ; bug#20201
`(keymap
,indicator
(turn-off menu-item "Turn off minor mode" ,mm-fun)
(help menu-item "Help for minor mode"
(lambda () (interactive)
(describe-function ',mm-fun)))))))
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no