[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#21284: 25.0.50; `completion-file-name-table' should/not use `nrevers
bug#21284: 25.0.50; `completion-file-name-table' should/not use `nreverse'?
Tue, 07 Jun 2016 05:36:30 +0300
> Date: Mon, 06 Jun 2016 13:00:40 -0700
> From: Keith David Bershatsky <address@hidden>
> Cc: address@hidden,Marcin Borkowski <address@hidden>,Noam Postavsky
> If there is/are valid reason(s) to reverse the order, then perhaps consider
> mentioning one or more of those reasons in a comment within
> `completion-file-name-table' along with a mention of bug 21284.
> If there is no valid reason whatsoever to reverse the order, then perhaps
> consider removing `nreverse` from `completion-file-name-table`.
> If the issue is "de minimus", then the bug report can be closed without
> further ado.
I believe the reason is the usual one: we create the list by pushing
each new element onto it, so the result comes in reverse order of the
files. The call to nreverse then restores the original order. IOW,
this is an implementation detail.