[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#23769: 25.0.95; Mode Line breakage in vc-git

From: Dmitry Gutov
Subject: bug#23769: 25.0.95; Mode Line breakage in vc-git
Date: Thu, 16 Jun 2016 02:25:43 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2

On 06/16/2016 01:09 AM, Phillip Lord wrote:

Try it on a pre-commit hook. CWD is set to the root, and GIT_DIR is set
to .git. Other people have found this:


OK, so hooks set it themselves.

AFAICT, it's not actually documented by git. Or it is but the
documentation is incomprehensible (hey, it's git, it could happen!).


That situation does indeed happen. For example, I normally checkout
emacs into worktrees where you get this when commiting on emacs-25
branch which is a worktree off master.

Does git-worktree use GIT_DIR in some way?

There is a simpler option. I am trying to solve the root cause of the
problem but, as you say, that might be fraught. Since the problem only
seems to cause an error with vc-git-mode-line-string, we could just
discard the error from vc-git-working-revision in this case.

That sounds like a last-resort option.

Failing that, now I know what the problem is, at least I have a
workaround (unset GIT_DIR in the pre-commit hook).

We could also unset GIT_DIR locally inside vc-git--call. At least when it's set to a known value such as '.git'.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]