[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-
bug#23945: 25.1.50; Request for review: Gnus Cloud work in scratch/gnus-cloud
Mon, 18 Jul 2016 19:18:09 -0400
Gnus/5.13 (Gnus v5.13) Emacs/25.0.93 (gnu/linux)
Ted Zlatanov <firstname.lastname@example.org> writes:
> On Wed, 13 Jul 2016 10:20:12 -0400 Ted Zlatanov <email@example.com> wrote:
> TZ> On Mon, 11 Jul 2016 11:05:55 -0400 Teodor Zlatanov <firstname.lastname@example.org>
> TZ> I've published the proposed changes to the Gnus Cloud code in the branch
> TZ> `scratch/gnus-cloud' and would like to request a code review. It's a
> TZ> single commit which I've tested over the last 2 weeks with the help of
> TZ> other Gnus users.
> TZ> I'll add documentation if the code is acceptable.
> TZ> There is one piece I remembered was missing: making the cloud host
> TZ> persistent.
> I converted `gnus-cloud-method' to a defcustom and added the necessary
> code to set it, resolving this question.
> Since no one has been interested in reviewing this code, I will merge it
Perhaps this is partly because I'm not familiar with the code (or what
"Gnus Cloud" is), but it seems to me that you're missing a good summary
line explaining what any of these changes are for. The bug title and
commit message summary line mentions only "Gnus Cloud work". What
"work"? This feels actively reviewer-hostile.
The 2nd commit titled "Minor gnus-cloud UI improvements" is a bit better
(at least we can tell it's about UI), though adding 20 or so "Merge
branch 'master' of git.sv.gnu.org:/srv/git/emacs" in between doesn't
help much either.