[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24071: [PATCH] Refactor regex character class parsing in [:name:]
From: |
Eli Zaretskii |
Subject: |
bug#24071: [PATCH] Refactor regex character class parsing in [:name:] |
Date: |
Wed, 27 Jul 2016 19:28:25 +0300 |
> From: Michal Nazarewicz <mina86@mina86.com>
> Cc: 24071@debbugs.gnu.org
> Date: Wed, 27 Jul 2016 17:29:04 +0200
>
> > If we are going to make some serious refactoring in regex.c, I think
> > we should start with having a test suite for it.
>
> I agree. Which is why I started test/src/regex-tests.el¹. Since this
> patch touches only character classes I limited the tests to character
> classes.
I know. What I wrote was not a complaint about the past, it was a
suggestion for the future. A single localized change doesn't yet
justify importing a large test suite. But this later patch looks like
a beginning of a series of refactoring (is it?), hopefully followed by
more features, so I thought we should have a firm ground first.
> > The dima_regex_embedded_modifiers branch, created by Dima Kogan
> > (CC'ed) in the Emacs repository includes a suite taken from glibc.
> > Dima, could you perhaps merge the parts of the test suite that can
> > already be used to the master branch, so that we could use them to
> > verify changes in regex.c?
>
> This looks relatively straightforward; I can take care of it. I’ll
> send a link to the result soon.
Thanks.
- bug#24071: [PATCH] Refactor regex character class parsing in [:name:], Michal Nazarewicz, 2016/07/25
- bug#24071: [PATCH] Refactor regex character class parsing in [:name:], Eli Zaretskii, 2016/07/26
- bug#24071: [PATCH 1/7] New regex tests imported from glibc 2.21, Michal Nazarewicz, 2016/07/27
- bug#24071: [PATCH 3/7] Fix reading of regex-resources in regex-tests, Michal Nazarewicz, 2016/07/27
- bug#24071: [PATCH 4/7] Don’t (require 'cl), Michal Nazarewicz, 2016/07/27
- bug#24071: [PATCH 7/7] Refactor regex character class parsing in [:name:], Michal Nazarewicz, 2016/07/27
- bug#24071: [PATCH 5/7] Split regex glibc test cases into separet tests, Michal Nazarewicz, 2016/07/27
- bug#24071: [PATCH 6/7] Remove dead opcodes in regex bytecode, Michal Nazarewicz, 2016/07/27
- bug#24071: [PATCH 2/7] Added driver for the regex tests, Michal Nazarewicz, 2016/07/27
- bug#24071: [PATCH] Refactor regex character class parsing in [:name:], Dima Kogan, 2016/07/29