bug-gnu-emacs
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .j


From: Eli Zaretskii
Subject: bug#24317: 25.1.50; image-dired-rotate-original: regexp doesn't match .jpeg suffix
Date: Sat, 27 Aug 2016 11:57:47 +0300

> From: Tino Calancha <address@hidden>
> Date: Sat, 27 Aug 2016 17:53:49 +0900 (JST)
> cc: Tino Calancha <address@hidden>, address@hidden
> 
> > I understand why we need to fix a typo in the regexp (which the log
> > entry doesn't even mention, btw), but what's the rationale for making
> > it a defvar?
> I made a defvar because it was used in 2 functions: only one show the 
> typo.

In that case, why not make a function that does the string-match as
well, in which case you won't need a variable, because it will appear
in a single place, and will also have the test localized to a single
function?

Thanks.





reply via email to

[Prev in Thread] Current Thread [Next in Thread]