[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24372: 25.1.50; After losing focus, cursor is hidden when moving poi
From: |
Eli Zaretskii |
Subject: |
bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point |
Date: |
Fri, 23 Sep 2016 17:28:22 +0300 |
> Date: Sun, 11 Sep 2016 22:18:38 +0300
> From: Eli Zaretskii <eliz@gnu.org>
> Cc: 24372@debbugs.gnu.org
>
> > How about a variant of this below? It uses a fixed limitation from
> > below on the delay, but only for the first blink. (The value 0.2 was
> > found by experimentation, not sure if we need to add yet another
> > defcustom for that.)
> >
> > I don't think we should introduce magic numbers or further customization
> > options.
>
> It solves the problem, doesn't it? I don't mind very much if it were
> a defcustom, I just think no one would want to change it.
>
> > > I've attached another patch with the change I have in mind.
> >
> > This has a disadvantage of creating a new timer object each time,
> > which I think we'd like to avoid: too much consing. (Also, don't you
> > need to set the timer variable to nil when the timer is disabled?)
> >
> > I don't understand - the patch doesn't create any additional timers, it
> > only changes the initial delay of the
> > idle-timer.
>
> Each time blink-cursor--start-timer or blink-cursor--start-idle-timer
> is called, they create a new timer, right? And your patch makes us
> call these functions each time blinking is started or ended, right?
>
> > My patch is identical, except is uses blink-cursor-interval as lower bound.
>
> Of course. That's why I said it's a minor variant.
>
> There's another difference, though: in my patch we only limit the
> first argument to run-with-timer/run-with-idle-timer, not the second.
> So only the first blink cycle is affected.
No further comments, so I pushed my last proposed patch to the
emacs-25 branch, and I'm marking this bug done.
Thanks.
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point, (continued)
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point, Eli Zaretskii, 2016/09/09
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point, Philipp Stephani, 2016/09/09
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point, Philipp Stephani, 2016/09/09
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point, Philipp Stephani, 2016/09/09
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point, Philipp Stephani, 2016/09/09
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point, Eli Zaretskii, 2016/09/10
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point, Philipp Stephani, 2016/09/11
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point, Eli Zaretskii, 2016/09/11
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point, Philipp Stephani, 2016/09/11
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point, Eli Zaretskii, 2016/09/11
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point,
Eli Zaretskii <=
- bug#24372: 25.1.50; After losing focus, cursor is hidden when moving point, Philipp Stephani, 2016/09/25