[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key
bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords
Sat, 01 Oct 2016 11:28:07 +0300
> From: Dima Kogan <address@hidden>
> Cc: address@hidden, address@hidden
> Date: Sun, 25 Sep 2016 11:44:23 -0700
> > Thanks. However, this doesn't look right to me: your code is entirely
> > inside the following condition:
> > if (event->kind == ASCII_KEYSTROKE_EVENT)
> > So it will not do anything for non-ASCII keystrokes. You should move
> > the code out of that condition, I think.
> >> + if (uppercasep(c) &&
> >> + !(event->modifiers & shift_modifier) )
> > A nit: our coding standards request a space between the function name
> > and the opening parenthesis that follows it, and no spaces between
> > closing parentheses.
> OK. How about this?
Looks okay, but you still didn't leave a space before the opening
parentheses and the function name.
Did you try this with a non-ASCII key (assuming you have one on your
- bug#24456: 25.1; [PATCH] Caps-lock doesn't affect interpretation of key chords,
Eli Zaretskii <=