[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24579: [PATCH] borderless windows on OS X

From: Alan Third
Subject: bug#24579: [PATCH] borderless windows on OS X
Date: Sat, 1 Oct 2016 22:26:13 +0100
User-agent: Mutt/1.7.0 (2016-08-17)

On Fri, Sep 30, 2016 at 09:31:09PM -0400, Jay McCarthy wrote:
> There are two popular Emacs patches for OS X that make all its windows
> have no title bar:
> https://github.com/nikhilunni/BorderlessEmacs
> https://github.com/gwydirsam/emacs-mac-borderless
> This patch integrates these by providing a variable
> (ns-use-titled-windows) that allows this decision to be controlled at
> runtime. The default is to use titles, like normal.

I’d prefer a variable name more like ‘ns-use-titlebar’, as
‘titled-windows’ doesn’t mean very much to me.

> -- Some comments on the patch
> This is my first Emacs patch. I hope it's okay.
> The only difference between EmacsFSWindow and EmacsWindow is
> explicitly telling OS X that the window can be the subject of focus,
> which is required for borderless windows. (EmacsFSWindow has nothing
> to do with being fullscreen.)

I’d no idea about this, do we even need both types?

> I included a note in the Changelog, because it looks like all
> variables like this get put in, but it could be removed from my
> perspective... I have no need to satisfy my pride with my name in the
> log. However, I didn't add anything to NEWS, because it seems to not
> always mention things like this.

The changelog is automatically updated from the git repository log, as
I understand it. We’ll commit it using your name so you’ll be credited
anyway. :)

Also, I don’t think this patch will be included before Emacs 26.1 as
it’s a new feature, not a bug fix, so the entry in cus-start.el may
need to read 26.1.

This one’s a real nit‐pick: I don’t like the version number being on
the next line in the variable doctype. I don’t see any reason why it
can’t be moved up on to the previous line next to the greater‐than
sign. And also change ‘windows’ to ‘frames’ and ‘title’ to ‘titlebar’.

I can’t see anything wrong other than my little moans above, and it
certainly looks like it does what it’s supposed to do. Thanks for
doing this.
Alan Third

reply via email to

[Prev in Thread] Current Thread [Next in Thread]