[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

bug#24633: highlight-region func using (window-hscroll) in :align-to spe

From: npostavs
Subject: bug#24633: highlight-region func using (window-hscroll) in :align-to spec can cause inf loop
Date: Sat, 22 Oct 2016 16:43:54 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux)

tags 24633 fixed
close 24633 26

Eli Zaretskii <address@hidden> writes:

>> From: address@hidden
>> Cc: address@hidden
>> Date: Sat, 22 Oct 2016 15:27:42 -0400
>> I tried adding a counter in redisplay_internal, it prevents having a
>> tight loop in C.  Actually, the behaviour becomes like the split window
>> case: there is additional hscrolling each time the cursor blinks, but it
>> can be interrupted with C-g.  That seems adequate behaviour to me, what
>> do you think?
> Did you see what happens when blink-cursor-mode is turned off?  (If
> that's what you meant by "each time the cursor blinks; if not, what
> caused it to blink?)

If I turn blink-cursor-mode off, then it stops scrolling after what
seems like immediately (though I can see from the message calls that the
highlight-region function was called several times).  So the counter is
limiting redisplay looping as expected.

> The patch looks OK to me, so if it gives better results than locking
> up Emacs with the current code, let's push it to master.

Okay, pushed as 241ae7a1 "Avoid infinite hscrolling in redisplay", and
closing the bug as fixed.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]